Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e testcases for REST based remote functions #23777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add e2e testcases for REST based remote functions #23777

wants to merge 1 commit into from

Conversation

Joe-Abraham
Copy link
Contributor

@Joe-Abraham Joe-Abraham commented Oct 7, 2024 •
edited
Loading

@Joe-Abraham Joe-Abraham force-pushed the function_server branch 8 times, most recently from ad8da3e to 775acbd Compare October 11, 2024 08:03
@Joe-Abraham Joe-Abraham force-pushed the function_server branch 6 times, most recently from 9aecd97 to 68d6174 Compare November 4, 2024 11:05
@Joe-Abraham Joe-Abraham force-pushed the function_server branch 4 times, most recently from 62cd292 to 744087e Compare November 8, 2024 04:39
@Joe-Abraham Joe-Abraham force-pushed the function_server branch 4 times, most recently from c79c741 to 128a517 Compare November 19, 2024 08:15
@Joe-Abraham Joe-Abraham force-pushed the function_server branch 4 times, most recently from 38bee26 to f518759 Compare November 27, 2024 08:52
@Joe-Abraham Joe-Abraham marked this pull request as ready for review November 28, 2024 03:51
@Joe-Abraham Joe-Abraham requested review from shrinidhijoshi and a team as code owners November 28, 2024 03:51
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Nov 28, 2024
@prestodb-ci prestodb-ci requested review from a team, auden-woolfson and imsayari404 and removed request for a team November 28, 2024 03:51
@Joe-Abraham Joe-Abraham force-pushed the function_server branch 2 times, most recently from 26886d1 to 2f9880d Compare November 28, 2024 03:58
abevk2023
abevk2023 reviewed Dec 2, 2024
View reviewed changes
docker/Dockerfile
ARG JMX_PROMETHEUS_JAVAAGENT_VERSION=0.20.0

ENV PRESTO_HOME="/opt/presto-server"

COPY $PRESTO_PKG .
COPY $PRESTO_CLI_JAR /opt/presto-cli
COPY $PRESTO_REMOTE_SERVER_JAR /opt/presto-remote-server

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unwanted line

docker/entrypoint.sh
@@ -2,4 +2,6 @@

set -e

java -Dconfig=/opt/function-server/etc/config.properties -jar /opt/presto-remote-server >> log1.txt 2>&1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove temporary log.

presto-native-execution/pom.xml
@@ -433,7 +439,7 @@
<args>
<BUILD_TYPE>Release</BUILD_TYPE>
<DEPENDENCY_IMAGE>presto-native-dependency:latest</DEPENDENCY_IMAGE>
<EXTRA_CMAKE_FLAGS>-DPRESTO_ENABLE_TESTING=OFF</EXTRA_CMAKE_FLAGS>
<EXTRA_CMAKE_FLAGS>-DPRESTO_ENABLE_REMOTE_FUNCTIONS=ON</EXTRA_CMAKE_FLAGS>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep existing CMAKE flags

...tive-execution/src/test/java/com/facebook/presto/nativeworker/ContainerQueryRunnerUtils.java
// "-Dplugin.dir=/opt/presto-remote-server/function-server-plugin " +
// "-Dconfig=/opt/presto-remote-server/function-server-etc/config.properties " +
// "-jar /opt/presto-remote-server >> log1.txt 2>&1 & \n" +
"-Dconfig=/opt/function-server/etc/config.properties -jar /opt/presto-remote-server >> log1.txt 2>&1 & \n" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

...cution/src/test/java/com/facebook/presto/nativeworker/TestPrestoContainerRemoteFunction.java
computeActual("select remote.default.length(CAST('AB' AS VARBINARY))")
.getMaterializedRows().get(0).getField(0).toString(),
"2");
assertEquals(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test for scalar functions which is available only in remote function server, not in native. like from_base32

presto> select remote.default.from_base32(CAST('MFRGG===' AS VARBINARY));
presto> select remote.default.to_base32(CAST('abc' AS VARBINARY));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abevk2023 abevk2023 abevk2023 left review comments

@shrinidhijoshi shrinidhijoshi Awaiting requested review from shrinidhijoshi

@jaystarshot jaystarshot Awaiting requested review from jaystarshot

@feilong-liu feilong-liu Awaiting requested review from feilong-liu

@elharo elharo Awaiting requested review from elharo

@ClarenceThreepwood ClarenceThreepwood Awaiting requested review from ClarenceThreepwood

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@auden-woolfson auden-woolfson Awaiting requested review from auden-woolfson auden-woolfson was automatically assigned from prestodb/ibm-reviewers

@imsayari404 imsayari404 Awaiting requested review from imsayari404 imsayari404 was automatically assigned from prestodb/ibm-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joe-Abraham @abevk2023 @prestodb-ci